Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pip-test-package instead of virtualenv #1726

Merged
merged 1 commit into from
Apr 18, 2014
Merged

Use pip-test-package instead of virtualenv #1726

merged 1 commit into from
Apr 18, 2014

Conversation

Ivoz
Copy link
Contributor

@Ivoz Ivoz commented Apr 16, 2014

Thanks to #1721

Change checked out package to be pip-test-package, instead of virtualenv.

Observe old:

 pip ivo·ivosung ~/code/pypa/pip develop ± time py.test tests/functional/test_install.py -k test_install_using_install_option_and_editable
=============================================================================================== test session starts ================================================================================================
platform linux2 -- Python 2.7.6 -- py-1.4.20 -- pytest-2.5.2
collected 40 items 

tests/functional/test_install.py .

==================================================================== 39 tests deselected by '-ktest_install_using_install_option_and_editable' =====================================================================
===================================================================================== 1 passed, 39 deselected in 68.95 seconds =====================================================================================

real  1m9.146s
user  0m4.440s
sys   0m1.570s

Observe new:

 pip ivo·ivosung ~/code/pypa/pip speedup_test_editable ± time py.test tests/functional/test_install.py -k test_install_using_install_option_and_editable
=============================================================================================== test session starts ================================================================================================
platform linux2 -- Python 2.7.6 -- py-1.4.20 -- pytest-2.5.2
collected 40 items 

tests/functional/test_install.py .

==================================================================== 39 tests deselected by '-ktest_install_using_install_option_and_editable' =====================================================================
===================================================================================== 1 passed, 39 deselected in 3.93 seconds ======================================================================================

real  0m4.132s
user  0m2.397s
sys   0m0.413s

@Ivoz Ivoz mentioned this pull request Apr 16, 2014
Closed
11 tasks
qwcode
qwcode reviewed Apr 16, 2014
View reviewed changes
tests/functional/test_install.py
)
assert virtualenv_bin in result.files_created
# import pdb; pdb.set_trace()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extraneous line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers =_=

Ivoz added a commit that referenced this pull request Apr 18, 2014
@Ivoz
Merge pull request #1726 from Ivoz/speedup_test_editable
9539ce2 
Use pip-test-package instead of virtualenv
@Ivoz Ivoz merged commit 9539ce2 into pypa:develop Apr 18, 2014
@Ivoz Ivoz deleted the speedup_test_editable branch April 18, 2014 06:33
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ivoz @qwcode